Update LeakCanary library #10085

TacoTheDank · 2023-05-11T23:42:35Z

What is it?

Bugfix (user facing)
Feature (user facing)
Codebase improvement (dev facing)
Meta improvement to the project (dev facing)

Description of the changes in your PR

Update LeakCanary library 2.9.1 -> 2.12 (changelog)
Fix LeakCanary deprecations

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

I read the contribution guidelines.

AudricV · 2023-05-18T14:08:38Z

Version 2.11 has been released yesterday and it fixes some bugs. Could you bump the version update to this version and try to see if everything still works fine?

TacoTheDank · 2023-05-22T21:58:58Z

Done. Things look fine.

sonarcloud · 2023-05-30T16:53:42Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

sonarcloud · 2023-07-12T00:44:10Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

Stypox · 2023-07-12T17:05:21Z

app/build.gradle

    implementation "com.squareup.leakcanary:leakcanary-object-watcher-android:${leakCanaryVersion}"
    implementation "com.squareup.leakcanary:plumber-android:${leakCanaryVersion}"


Mmmh, why are these not debugImplementation?

TobiGr · 2023-07-14T13:14:02Z

I get this crash when Android Studio tries to lauch the app after installing it. It's an endless loop. Debug builds cannot be run.

FATAL EXCEPTION: main
Process: org.schabi.newpipe.debug.bugfixfeedcrash, PID: 6951
java.lang.RuntimeException: Unable to create application org.schabi.newpipe.DebugApp: java.lang.IllegalStateException: AppWatcher already installed, see exception cause for prior install call
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6717)
	at android.app.ActivityThread.access$1300(ActivityThread.java:237)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1913)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:223)
	at android.app.ActivityThread.main(ActivityThread.java:7656)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
Caused by: java.lang.IllegalStateException: AppWatcher already installed, see exception cause for prior install call
	at leakcanary.AppWatcher.manualInstall(AppWatcher.kt:98)
	at leakcanary.AppWatcher.manualInstall$default(AppWatcher.kt:94)
	at org.schabi.newpipe.DebugApp.onCreate(DebugApp.kt:17)
	at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1192)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6712)
	at android.app.ActivityThread.access$1300(ActivityThread.java:237) 
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1913) 
	at android.os.Handler.dispatchMessage(Handler.java:106) 
	at android.os.Looper.loop(Looper.java:223) 
	at android.app.ActivityThread.main(ActivityThread.java:7656) 
	at java.lang.reflect.Method.invoke(Native Method) 
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) 
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947) 
Caused by: java.lang.RuntimeException: manualInstall() first called here
	at leakcanary.AppWatcher.manualInstall(AppWatcher.kt:116)
	at leakcanary.AppWatcher.manualInstall$default(AppWatcher.kt:94)
	at leakcanary.internal.MainProcessAppWatcherInstaller.onCreate(MainProcessAppWatcherInstaller.kt:21)
	at android.content.ContentProvider.attachInfo(ContentProvider.java:2388)
	at android.content.ContentProvider.attachInfo(ContentProvider.java:2358)
	at android.app.ActivityThread.installProvider(ActivityThread.java:7239)
	at android.app.ActivityThread.installContentProviders(ActivityThread.java:6780)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6697)
	at android.app.ActivityThread.access$1300(ActivityThread.java:237) 
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1913) 
	at android.os.Handler.dispatchMessage(Handler.java:106) 
	at android.os.Looper.loop(Looper.java:223) 
	at android.app.ActivityThread.main(ActivityThread.java:7656) 
	at java.lang.reflect.Method.invoke(Native Method) 
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) 
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947) 
2023-07-14 15:11:46.152  6951-6951  ACRA                    org...newpipe.debug.bugfixfeedcrash  E  ACRA caught a RuntimeException for org.schabi.newpipe.debug.bugfixfeedcrash
java.lang.RuntimeException: Unable to create application org.schabi.newpipe.DebugApp: java.lang.IllegalStateException: AppWatcher already installed, see exception cause for prior install call
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6717)
	at android.app.ActivityThread.access$1300(ActivityThread.java:237)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1913)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:223)
	at android.app.ActivityThread.main(ActivityThread.java:7656)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
Caused by: java.lang.IllegalStateException: AppWatcher already installed, see exception cause for prior install call
	at leakcanary.AppWatcher.manualInstall(AppWatcher.kt:98)
	at leakcanary.AppWatcher.manualInstall$default(AppWatcher.kt:94)
	at org.schabi.newpipe.DebugApp.onCreate(DebugApp.kt:17)
	at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1192)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6712)
	at android.app.ActivityThread.access$1300(ActivityThread.java:237) 
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1913) 
	at android.os.Handler.dispatchMessage(Handler.java:106) 
	at android.os.Looper.loop(Looper.java:223) 
	at android.app.ActivityThread.main(ActivityThread.java:7656) 
	at java.lang.reflect.Method.invoke(Native Method) 
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) 
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947) 
Caused by: java.lang.RuntimeException: manualInstall() first called here
	at leakcanary.AppWatcher.manualInstall(AppWatcher.kt:116)
	at leakcanary.AppWatcher.manualInstall$default(AppWatcher.kt:94)
	at leakcanary.internal.MainProcessAppWatcherInstaller.onCreate(MainProcessAppWatcherInstaller.kt:21)
	at android.content.ContentProvider.attachInfo(ContentProvider.java:2388)
	at android.content.ContentProvider.attachInfo(ContentProvider.java:2358)
	at android.app.ActivityThread.installProvider(ActivityThread.java:7239)
	at android.app.ActivityThread.installContentProviders(ActivityThread.java:6780)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6697)

TacoTheDank · 2023-07-14T17:01:29Z

@TobiGr Fixed. I forgot to disable the auto-install. #10231

AudricV added the codequality Improvements to the codebase to improve the code quality label May 12, 2023

TacoTheDank force-pushed the bumpLeakCanary branch from 912240d to d2d083a Compare May 22, 2023 21:58

TacoTheDank force-pushed the bumpLeakCanary branch from d2d083a to 6775f20 Compare May 30, 2023 16:38

Update LeakCanary library

db7de05

TacoTheDank force-pushed the bumpLeakCanary branch from 6775f20 to db7de05 Compare July 12, 2023 00:32

Stypox approved these changes Jul 12, 2023

View reviewed changes

Stypox merged commit f8599d1 into TeamNewPipe:dev Jul 12, 2023

TacoTheDank deleted the bumpLeakCanary branch July 14, 2023 16:42

TacoTheDank mentioned this pull request Jul 14, 2023

Fix LeakCanary crash #10231

Closed

5 tasks

Stypox mentioned this pull request Jul 14, 2023

Fix LeakCanary startup in debug builds and fix a memory leak #10232

Merged

5 tasks

This was referenced Jul 31, 2023

Release v0.25.2 (994) #10283

Merged

Release v0.25.2 (please TEST!) #10284

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update LeakCanary library #10085

Update LeakCanary library #10085

TacoTheDank commented May 11, 2023 •

edited

Loading

AudricV commented May 18, 2023

TacoTheDank commented May 22, 2023 •

edited

Loading

sonarcloud bot commented May 30, 2023

sonarcloud bot commented Jul 12, 2023

Stypox Jul 12, 2023

TobiGr commented Jul 14, 2023 •

edited

Loading

TacoTheDank commented Jul 14, 2023

		implementation "com.squareup.leakcanary:leakcanary-object-watcher-android:${leakCanaryVersion}"
		implementation "com.squareup.leakcanary:plumber-android:${leakCanaryVersion}"

Update LeakCanary library #10085

Update LeakCanary library #10085

Conversation

TacoTheDank commented May 11, 2023 • edited Loading

What is it?

Description of the changes in your PR

APK testing

Due diligence

AudricV commented May 18, 2023

TacoTheDank commented May 22, 2023 • edited Loading

sonarcloud bot commented May 30, 2023

sonarcloud bot commented Jul 12, 2023

Stypox Jul 12, 2023

Choose a reason for hiding this comment

TobiGr commented Jul 14, 2023 • edited Loading

TacoTheDank commented Jul 14, 2023

TacoTheDank commented May 11, 2023 •

edited

Loading

TacoTheDank commented May 22, 2023 •

edited

Loading

TobiGr commented Jul 14, 2023 •

edited

Loading