Fix downloads of streams with missing MediaFormat #10165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
bug
TobiGr
changed the title
6 tasks
TobiGr
force-pushed
the
fix/media-format
branch
4 times, most recently
from
8e2daa4 to
d0c1919
Compare
Stypox
requested changes
Aug 6, 2023
app/src/main/java/org/schabi/newpipe/util/StreamItemAdapter.java
Outdated
Show resolved
Hide resolved
TobiGr
force-pushed
the
fix/media-format
branch
from
fb23e75 to
2fd8b50
Compare
TobiGr
force-pushed
the
fix/media-format
branch
from
2fd8b50 to
ba84e7e
Compare
|
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
approved these changes
Sep 19, 2023
| } | ||
|
|
||
| // extract the file extension / suffix | ||
| final String[] p = fileName.split("\\."); |
There was a problem hiding this comment.
I was going to say "split this without using a regex" but then stumbled upon this: https://stackoverflow.com/a/60048140
| // try to get the format by content type | ||
| // some mime types are not unique for every format, those are omitted | ||
| final List<MediaFormat> formats = MediaFormat.getAllFromMimeType( | ||
| response.getHeader("Content-Type")); |
There was a problem hiding this comment.
response.getHeader("Content-Type") will return null if there are no such headers. Fortunately that's not a problem since getAllFromMimeType works normally with null strings, but it should be changed anyway. The loop below can also be optimized to exit-early as soon as a conflicting media format is found, and also to prevent creating a new list.
Also check for nullity
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Oct 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Rertrieve
MediaFormats for streams in case the extractor was not able to get them. Sometimes the MediaFormat can be retrieved from the HTTP response header that is fetched when getting the stream size.The dialog now also displays "Unknown Quality" if the quality is unknown. Previously, the media format name was displayed as title and as quality info.
Some code improvements simplifying castings by directly casting in if-conditions using
instanceofBefore/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
TeamNewPipe/NewPipeExtractor#1074
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence