Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows to use Node 20 #10908

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Update workflows to use Node 20 #10908

merged 2 commits into from
Mar 27, 2024

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Mar 26, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This updates the use of actions that still rely on Node 16.
Workflow that ran with the updated actions: https://github.com/TobiGr/NewPipe/actions/runs/8443331003
More info: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Before/After Screenshots/Screen Record

grafik

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

TobiGr added 2 commits March 26, 2024 22:32
Updates deprecated Node 16 to 20
Updates deprecated Node 16 to 20
@TobiGr TobiGr added the meta Related to the project but not strictly to code label Mar 26, 2024
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Mar 26, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Stypox Stypox merged commit 434c4a5 into dev Mar 27, 2024
8 of 9 checks passed
@TobiGr TobiGr deleted the node-20 branch March 27, 2024 19:06
@Stypox Stypox mentioned this pull request Apr 1, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code size/small PRs with less than 50 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants