Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PeerTube] Handle subscribeto.me instance links automatically #11110

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

Neznak
Copy link

@Neznak Neznak commented May 27, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR fixes the handling of subscribeto.me Peertube links on NewPipe.

Before/After Screenshots/Screen Record

  • Before:
before.F.mp4
  • After:
after.F.mp4

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label May 27, 2024
@Neznak Neznak changed the title Add missing Peertube instance subscribeto.me to the links Newpipe han… Add missing Peertube instance to the links Newpipe handles May 27, 2024
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@TobiGr TobiGr added the peertube Service, https://joinpeertube.org/ label Jun 17, 2024
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@TobiGr TobiGr changed the title Add missing Peertube instance to the links Newpipe handles [Peertube] Handle subscribeto.me instance links automatically Jun 17, 2024
@TobiGr TobiGr merged commit a2d93b3 into TeamNewPipe:dev Jun 17, 2024
11 checks passed
@AudricV AudricV changed the title [Peertube] Handle subscribeto.me instance links automatically [PeerTube] Handle subscribeto.me instance links automatically Jul 4, 2024
@Stypox Stypox mentioned this pull request Nov 17, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peertube Service, https://joinpeertube.org/ size/small PRs with less than 50 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants