-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/autoplay switch button highlight colour #4162
Feature/autoplay switch button highlight colour #4162
Conversation
What made you choose green for this? I would have thought that the enabled toggle would be the same colour as the service currently being used. Or, since all the toggles in the app settings are red, the enabled toggle would also be that same red. |
@opusforlife2, have made toggle as white. |
Now I'm confused. As I said in the issue, the toggle is already white when enabled. Did you change it to a different white? Personally, as I said above, I would like the toggle to match the service colour of whichever service is active. If that isn't possible, then it should be the same red as all the toggles in Newpipe's settings. But the devs and other users may have different opinions on this, so I think you should wait for some others to comment. |
Yes, the toggle should match the service color. |
@TobiGr @opusforlife2, so toggle color should be red right. |
@Bawya1098 Red for Youtube, yes. Then orange for SoundCloud, a different orange for Peertube, and, if you want to be proactive, blue for Bandcamp (you can check the PR to see which blue, exactly). @TobiGr I was about to say grey for MediaCCC, but that's the same colour as the disabled toggle... what to do here? |
The red coloured toggle for YouTube looks awesome! |
But how do I change for peertube, SoundCloud |
@Bawya1098 |
@XiangRongLin: No, you shouldn't add or change any Java code for that… It could be fully done with the XML stuff, see the toolbar, subscribe button, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you apply the requested changes? Just use ?attr/colorPrimary
, e.g. see this commit: 80cc8a8
679bc75
to
2aeccc0
Compare
This feature has been long overdue. I think the original developer has given up. Someone have to takeover this pull request. |
I tried but I couldn't understand how to change the switch colors just by changing XML files |
Closing in favour of #6456 |
What is it?
Fixes the following issue(s)
Description of the changes in your PR
Autoplay ON
Autoplay OFF
Test Apk
app-debug.apk.zip
Agreement