Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/autoplay switch button highlight colour #4162

Conversation

Bawya1098
Copy link

@Bawya1098 Bawya1098 commented Aug 19, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)

Fixes the following issue(s)

Description of the changes in your PR

Autoplay ON
Screenshot_1597900874

Autoplay OFF
Screenshot_1597900879

Test Apk
app-debug.apk.zip

Agreement

@opusforlife2
Copy link
Collaborator

What made you choose green for this? I would have thought that the enabled toggle would be the same colour as the service currently being used. Or, since all the toggles in the app settings are red, the enabled toggle would also be that same red.

@Bawya1098
Copy link
Author

@opusforlife2, have made toggle as white.

@opusforlife2
Copy link
Collaborator

Now I'm confused. As I said in the issue, the toggle is already white when enabled. Did you change it to a different white?

Personally, as I said above, I would like the toggle to match the service colour of whichever service is active. If that isn't possible, then it should be the same red as all the toggles in Newpipe's settings.

But the devs and other users may have different opinions on this, so I think you should wait for some others to comment.

@TobiGr
Copy link
Member

TobiGr commented Aug 19, 2020

Yes, the toggle should match the service color.

@opusforlife2 opusforlife2 changed the title Feature/autoplay swtich button highlight colour Feature/autoplay switch button highlight colour Aug 19, 2020
@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Aug 19, 2020
@Bawya1098
Copy link
Author

@TobiGr @opusforlife2, so toggle color should be red right.

@opusforlife2
Copy link
Collaborator

@Bawya1098 Red for Youtube, yes. Then orange for SoundCloud, a different orange for Peertube, and, if you want to be proactive, blue for Bandcamp (you can check the PR to see which blue, exactly).

@TobiGr I was about to say grey for MediaCCC, but that's the same colour as the disabled toggle... what to do here?

@opusforlife2
Copy link
Collaborator

The red coloured toggle for YouTube looks awesome!

@Bawya1098
Copy link
Author

But how do I change for peertube, SoundCloud
could you please help?

@XiangRongLin
Copy link
Collaborator

@Bawya1098
You could add a method to ServiceHelper to return the correct color for a given serviceId and then programmatically set it when the fragment is loaded. On first glance it looks like you'll need ServiceHelper.getSelectedServiceId()

@wb9688
Copy link
Contributor

wb9688 commented Aug 22, 2020

@XiangRongLin: No, you shouldn't add or change any Java code for that… It could be fully done with the XML stuff, see the toolbar, subscribe button, etc.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you apply the requested changes? Just use ?attr/colorPrimary, e.g. see this commit: 80cc8a8

@TobiGr TobiGr force-pushed the dev branch 2 times, most recently from 679bc75 to 2aeccc0 Compare March 16, 2021 08:24
@skyGtm
Copy link

skyGtm commented Jun 8, 2021

This feature has been long overdue. I think the original developer has given up. Someone have to takeover this pull request.

@Stypox
Copy link
Member

Stypox commented Jun 8, 2021

I tried but I couldn't understand how to change the switch colors just by changing XML files

@TobiGr TobiGr mentioned this pull request Jun 8, 2021
5 tasks
@TobiGr
Copy link
Member

TobiGr commented Jun 8, 2021

Closing in favour of #6456

@TobiGr TobiGr closed this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoplay switch highlight color
8 participants