Random fixes and improvements

[Stypox]

What is it?

• Bug fix (user facing)
• Feature (user facing)
• Code base improvement (dev facing)
• Meta improvement to the project (dev facing)

Fixes the following issue(s)

• Fix invisible play queue item drag button: Release 0.20.0 #4332 (comment) reverted this, as it is already covered by Player overlays now centered #4360
• Fix play queue close button always being white regardless of theme.
• Prevent touches behind minimized player: Release 0.20.0 #4332 (comment)
• Make player close button always white regardless of theme, like all other player controls.
• Make thumbnail in large-land minimized player a little bit bigger, since there is plenty of horizontal space.
• Fix Context.startForegroundService() did not then call Service.startForeground() crash, happening when the foreground service is started too late on really slow devices. So now I start the foreground service directly in onCreate(), instead of waiting for a play queue to arrive to onStartCommand() (see this SO and Release 0.20.0 #4332 (comment)). This shouldn't have any side-effect: I made sure there are no issues with notification initialization if the playback data is still not initialized and there can't be notification leaks since the notification is always deleted in the service's onDestroy(). Release 0.20.0 #4332 (comment)
• Fix video detail controls visibility set inconsistently, see the discussion on IRC and report on Reddit

Testing apk

I could not test on API 19 since the player won't open there (probably an issue with codecs, it used to work, I don't know why now it does not anymore), but it should work there, too.
app-debug.zip

Agreement

• I carefully read the contribution guidelines and agree to them.

[avently]

So every element in the player is white regardless of the theme but close button will be black in white theme?

[opusforlife2]

Wasn't this fixed by #4360?

[Stypox]

@avently the play queue background is white in white theme, therefore play queue close button should be black in that case. I'm not talking about the player close button, I didn't touch that.

[avently]

Oh, wait. Player close button from top left corner uses ?attr instead of being white always. Could you make it always white?

[Stypox]

@avently done. I also fixed another issue pointed out in the 0.20.0 thread: #4332 (comment). I updated the PR description accordingly.
app-debug.zip

[Stypox]

I now included in this PR a fix for the crash @Redirion was sometimes obtaining: #4332 (comment)
app-debug.zip

[Stypox]

Fix video detail controls visibility set inconsistently, see the discussion on IRC and report on Reddit
app-debug.zip

[avently]

You said you added notification in oncreate. You check how it works when media buttons starts the player? For example, connect via Bluetooth and press on play. You should play something in NewPipe before this check so android will route media action to newpipe

[avently]

Thank you for your work!

[Stypox]

You said you added notification in oncreate. You check how it works when media buttons starts the player? For example, connect via Bluetooth and press on play. You should play something in NewPipe before this check so android will route media action to newpipe

I didn't check this, I'm not sure what you are talking about 😅