Fix reload feed button does nothing

[Stypox]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

This was caused by view binding PR. initListeners was being called before the bindings were assigned, and therefore the click listener was never setup. @Isira-Seneviratne

Due diligence

• I read the contribution guidelines.

[Stypox]

@XiangRongLin could you review this? :-)

[XiangRongLin]

initListeners was being called before the bindings were assigned, and therefore the click listener was never setup

Add that reasoning to the commit message

[XiangRongLin]

Unrelated, but is it intended that it's possible for _feedbinding to be null while accessing it? For example here

NewPipe/app/src/main/java/org/schabi/newpipe/local/feed/FeedFragment.kt

Line 95 in 5e544e6

listState = _feedBinding?.itemsList?.layoutManager?.onSaveInstanceState()

If not, all usages of _feedbinding should be replaced with feedbinding, to not silently break features, but breaking them visibly

---

Also since you are already there, to me it looks like _errorBinding does not need that weird setup. It can just be a lateinit var. Because unlike _feedbinding it's not set to null in onDestroyView

[Stypox]

Also since you are already there, to me it looks like _errorBinding does not need that weird setup. It can just be a lateinit var. Because unlike _feedbinding it's not set to null in onDestroyView

_errorBinding will be removed completely in #5148, so I'm not taking care of it here (though I was tempted to ;-)) I did it anyway

If not, all usages of _feedbinding should be replaced with feedbinding, to not silently break features, but breaking them visibly

I agree, I'm going to remove them

[Stypox]

Done @XiangRongLin