-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tab layout visibility with age restricted videos #5563
Conversation
The layout problem is gone but could you make the play button to refresh the video since now when you go and enable restricted content on settings and come back to the video it doesn't [auto] refesh and the play button (on the minimized video) does nothing thus requiring you to close the video then you have to find the video again and play. |
3aa91a4
to
1e5dc01
Compare
@TobiGr I added comments. Regarding your Android-TV issue: that's not tv-specific and is expected behaviour. The tab layout is visible because the view pager is actually visible and has its tabs, since e.g. the comments could have been loaded regardless of whether the video shows a network error or not. Should the view pager be hidden completely in case of main-video network errors? |
@TobiGr I now pushed a commit that completely hides tabs both on age restricted content and on network errors (it can be reverted if unwanted). |
…-visibility Fix tab layout visibility with age restricted videos
What is it?
Description of the changes in your PR
This fixes the tab layout visibility in video detail fragment when showing age restricted videos:
Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence