Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the feature request template #7165

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Simplify the feature request template #7165

merged 1 commit into from
Oct 2, 2021

Conversation

opusforlife2
Copy link
Collaborator

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Reduced and simplified the sections in the feature request template.
  • Changed the comments to make them easier to understand.

Fixes the following issue(s)

  • Poor adherence to the template.

Due diligence

Making the experience of filling it out as hassle-free as possible would ensure fewer users ignore/misread the template.
@AudricV AudricV added the meta Related to the project but not strictly to code label Sep 24, 2021
@opusforlife2
Copy link
Collaborator Author

@mhmdanas It's waiting for a nonexistent CI check. How can this be fixed?

@triallax
Copy link
Contributor

Honestly, I'm not really sure. I'll try to take a look soon.

@triallax
Copy link
Contributor

@TobiGr do you have any idea if you can fiddle around with the repo's settings to fix this?

@TobiGr
Copy link
Member

TobiGr commented Sep 27, 2021

we cannot fix that without disabling the "Require status checks to pass before merging" setting. Maybe we need to re-think the approach and latthe test pass immideatly if one of these "skip"-conditions applies. I cannot find the PR which introduced the bahaviour (is it missing in the release notes?)

@triallax
Copy link
Contributor

I'm the one who opened that PR, so leave it up to me to clean the mess. :P

The PR is #6789 (just noticed the numbering, nice). You can revert it for now if you want.

@opusforlife2
Copy link
Collaborator Author

@mhmdanas @Poolitzer You guys still have to review it.

Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplification this is.

@triallax triallax merged commit 2e3e7f9 into dev Oct 2, 2021
@triallax triallax deleted the simplify_FR_template branch October 2, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants