Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Runnable variables for Handlers. #8886

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Aug 27, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Replace the Runnable variables being used in the downloader and double tap functionality with lambdas, and use String constants to keep track of them in the Handlers.

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@Isira-Seneviratne Isira-Seneviratne force-pushed the Remove_Runnable_variables branch from 5f5fca6 to 39b3f04 Compare August 27, 2022 08:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AudricV AudricV added the codequality Improvements to the codebase to improve the code quality label Sep 2, 2022
@Isira-Seneviratne Isira-Seneviratne force-pushed the Remove_Runnable_variables branch from 39b3f04 to c30f787 Compare November 4, 2022 01:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Stypox
Copy link
Member

Stypox commented Dec 18, 2022

You have added many unrelated changes (e.g. code style) and have not explained well what you did and how and why you did it. Please remove the unrelated changes and add a better PR description.

@Isira-Seneviratne Isira-Seneviratne force-pushed the Remove_Runnable_variables branch from c30f787 to 956fbd1 Compare December 19, 2022 14:13
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, now I can see what's happening. I think it's better to use string constants instead of duplicating the strings (I'm referring to "doubleTap", "next", "show", which should be converted to DOUBLE_TAP, NEXT, SHOW).

@Isira-Seneviratne Isira-Seneviratne force-pushed the Remove_Runnable_variables branch from 956fbd1 to d018556 Compare January 4, 2023 00:46
@Stypox Stypox force-pushed the Remove_Runnable_variables branch from d018556 to 9514316 Compare January 12, 2023 14:30
@Stypox
Copy link
Member

Stypox commented Jan 12, 2023

(the tests were failing)

/home/runner/work/NewPipe/NewPipe/app/src/main/java/org/schabi/newpipe/player/gesture/BasePlayerGestureListener.kt:40:1: Unexpected indentation (24) (should be 20) (indent)
/home/runner/work/NewPipe/NewPipe/app/src/main/java/org/schabi/newpipe/player/gesture/BasePlayerGestureListener.kt:73:1: Unexpected indentation (24) (should be 20) (indent)

@Stypox Stypox merged commit 062570c into TeamNewPipe:dev Jan 12, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Isira-Seneviratne Isira-Seneviratne deleted the Remove_Runnable_variables branch January 14, 2023 05:14
@Stypox Stypox mentioned this pull request Jan 22, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants