Fix crash when the user clicks download then quits the history fragment

[plasticanu]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Add a condition to detect if the user quits the current fragment. If the user clicked "Download" in the history fragment and then quit the history fragment, a DownloadDialog will not show and not crash the program.

Before/After Screenshots/Screen Record

• Before:

193872207-777dbbe8-256d-4e37-b0eb-8a85939ded64.mp4

• After:

Screen.Recording.2022-10-18.at.12.18.05.am.mov

Fixes the following issue(s)

• Fixes Download error. #9068

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[TobiGr]

Thank you. While you are at it, please add a @Nonnull annotation to the context parameter in the DownloadDialog constructor.

[plasticanu]

Thank you. While you are at it, please add a @Nonnull annotation to the context parameter in the DownloadDialog constructor.

Done.

[plasticanu]

Hi, I merged the latest dev from upstream to my branch, and then I can't pass the CI. I have to revert the merge, but then my pull request will change the build files to the previous version than the latest dev.
Is there anything I can do? I am not sure why the CI failed, it says can't find newPipe Extractor.

[Stypox]

Please revert the changes in both build.gradle and both AndroidManifest.xml. The other code looks good to me, thank you for taking care of this :-D. Don't worry about the CI failing, it's not your fault, but it seems to be a general problem of Jitpack.

[plasticanu]

Please revert the changes in both build.gradle and both AndroidManifest.xml. The other code looks good to me, thank you for taking care of this :-D. Don't worry about the CI failing, it's not your fault, but it seems to be a general problem of Jitpack.

Thanks. Done

[Stypox]

Thanks ;-)
Note that the null check could be extended to all other stream dialog entries: not only the download dialog could cause crashes. If you want to take care of that, please open a new PR.
I tested the changes myself as the CI isn't working at the moment.