Add language suffix to downloaded subtitle filenames #9499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SameenAhnaf
added
feature request
TobiGr
reviewed
Dec 25, 2022
app/src/main/java/org/schabi/newpipe/download/DownloadDialog.java
Outdated
Show resolved
Hide resolved
Stypox
requested changes
Jan 2, 2023
app/src/main/java/org/schabi/newpipe/download/DownloadDialog.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/download/DownloadDialog.java
Outdated
Show resolved
Hide resolved
Stypox
approved these changes
Jan 11, 2023
Stypox
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Added Language suffix for subtitle downloads.
Before/After Screenshots/Screen Record
before_.mp4
after_.mp4
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence