Remove duplicates from playlist feature

[Jared234]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Added a feature that allows users to remove duplicate streams from a local playlist.

Before/After Screenshots/Screen Record

Fixes the following issue(s)

• Fixes [Feature Request] Add the ability to remove duplicates in a playlist #1473

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[Stypox]

Thanks!

[Jared234]

Thanks for the review. I have implemented all your suggestions.

[Stypox]

Shouldn't this run in a separate thread, just like removeWatchedStreams? Also, while duplicates are being removed, the loading screen should be shown.

You could rename isRemovingWatched to isRewritingPlaylist and use it to prevent concurrent calls to removeDuplicates and removeWatched. Unfortunately this has never been the best solution (since there are other functions that change the playlist that are not guarded by that boolean, and so you might still get concurrent changes to the playlist), but there's no need to rework state handling in this PR (a viewmodel would be needed), so keep it as it was before.

[Stypox]

See this sonar warning: https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&pullRequest=9707&id=TeamNewPipe_NewPipe&open=AYXO4S5J5QjBB_bdSBLT

I think you can use our own R.string.ok (or R.string.yes). Same goes for cancel iirc.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Stypox]

Thank you, I tested it a bit, even with my database, and everything seems to work fine. Thanks! Sorry for the repeated comments, I had to make changes from my phone. I hope I have merged this in time, and good luck again with the exam ;-)

[Jared234]

Yes, all my projects are now finished by the deadline. Thank you very much for all the support. I really enjoyed working on NewPipe.