Created a setting to switch the sides of volume and brightness #9708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
requested changes
Jan 20, 2023
app/src/main/java/org/schabi/newpipe/player/gesture/MainPlayerGestureListener.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/player/gesture/MainPlayerGestureListener.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/settings/VideoAudioSettingsFragment.java
Outdated
Show resolved
Hide resolved
SameenAhnaf
added
feature request
|
I fixed a small bug. Now everything should be fine. |
|
Mmmh, after thinking about it, I think it's better to have two list options ("Gesture for left side", "Gesture for right side"), a where each option allows choosing amongst "None", "Audio control", "Brightness control". This also means that the user will be able to use one half of the screen for volume, and leave the other half without any gesture, which may help in some situations. This design is also future-proof if we decide to add more possible gesture actions. |
|
|
Stypox
requested changes
Feb 7, 2023
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
Outdated
Show resolved
Hide resolved
Stypox
requested changes
Feb 7, 2023
app/src/main/java/org/schabi/newpipe/player/gesture/MainPlayerGestureListener.kt
Outdated
Show resolved
Hide resolved
|
Did you think of a better name&description for the setting? |
Stypox
requested changes
Feb 7, 2023
Stypox
requested changes
Feb 26, 2023
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
requested changes
Apr 3, 2023
app/src/main/java/org/schabi/newpipe/settings/SettingMigrations.java
Outdated
Show resolved
Hide resolved
…GestureListener.kt Co-authored-by: Stypox <stypox@pm.me>
…ailFragment.java Co-authored-by: Stypox <stypox@pm.me>
Stypox
force-pushed
the
switch_setting_brightness_volume
branch
from
00f7169
to
d273560
Compare
Stypox
force-pushed
the
switch_setting_brightness_volume
branch
from
40ba85d
to
4bb45c0
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
approved these changes
Apr 4, 2023
This was referenced Jul 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Due diligence