Fix opening URLs in browser on API 30+ #9726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
What about the YouTube protocols? |
AudricV
added
bug
AudricV
changed the title
|
While we need to receive such links, do we ever need to open them in the browser? I don't think so |
TobiGr
approved these changes
Jan 29, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
See https://medium.com/androiddevelopers/package-visibility-in-android-11-cc857f221cd9 and #9615. I used what @plasticanu suggested, except that I also added "http" and "market" to the used schemas.
I tried to install the Kore app and everything works well even without adding
<package android:name="org.xbmc.kore" />to the possible queries, so I didn't add it in the end. I tested on API 33.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence