Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the landscape layout of list card item #9975

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Changed the landscape layout of list card item #9975

merged 1 commit into from
Mar 28, 2024

Conversation

Marius1501
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • changed the landscape layout of list card item
  • now it is the landscape layout of list item

Before/After Screenshots/Screen Record

  • Before:
    grafik

  • After:
    grafik

Fixes the following issue(s)

Due diligence

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SameenAhnaf SameenAhnaf added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Mar 27, 2023
@AudricV AudricV added feature request Issue is related to a feature in the app and removed bug Issue is related to a bug labels May 11, 2023
@TobiGr
Copy link
Contributor

TobiGr commented Aug 22, 2023

Is there a way to do this without creating duplicate code, e.g. by using <include> and <merge>?

@TobiGr TobiGr force-pushed the landscape_card_mode_improve branch from e030992 to 95c8c3b Compare September 17, 2023 22:44
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TobiGr
Copy link
Contributor

TobiGr commented Sep 17, 2023

I needed to wrap the include tag in an additional RelativeLayout. I was not able to find a better solution.

@TobiGr TobiGr requested a review from Stypox September 20, 2023 09:07
@Stypox
Changed the landscape layout of list card item
ddd6c8c 
Make layout-land/list_stream_card_item a symlink to layout/list_stream_item
@Stypox Stypox force-pushed the landscape_card_mode_improve branch from 95c8c3b to ddd6c8c Compare March 28, 2024 13:46
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Mar 28, 2024
@Stypox
Copy link
Member

Stypox commented Mar 28, 2024 •
edited
Loading

What about a symlink? I pushed a commit with a simple symlink of layout-land/list_stream_card_item to layout/list_stream_item. I built and tested and it works as intended.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Stypox Stypox merged commit 88c3af7 into TeamNewPipe:dev Mar 28, 2024
7 of 8 checks passed
@Stypox Stypox mentioned this pull request Apr 1, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface size/small PRs with less than 50 changed lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Card mode in landscape mode needs changes
5 participants
@Marius1501 @TobiGr @Stypox @AudricV @SameenAhnaf