[YouTube] Improve YoutubeStreamInfoItemExtractor #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Return duration of video premieres; - Add another non-localized method to determine whether a stream is a running livestream; - Return view count and upload date of videos in playlists; - Store isPremiere result; - Remove shorts workaround code, as it was only useful on channels and shorts have been moved into a separated channel tab; - Improve some other code.
AudricV
added
enhancement
|
1000! 🎉 |
FireMasterK
approved these changes
Dec 11, 2022
TobiGr
reviewed
Dec 11, 2022
| if (isPremiere()) { | ||
| // Premieres can be livestreams, so the duration is not available in this | ||
| // case | ||
| return -1; |
There was a problem hiding this comment.
We really need to introduce more constants for those default values in the Info classes. But that's something for another PR, maybe a good first issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, in order to avoid the corresponding build error): app-debug.zipThis PR improves some code in
YoutubeStreamInfoItemExtractorand:As a side effect, if duration of YouTube stream items cannot be extracted,
-1is always returned.