-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YouTube] Add support for ultralow audio formats #1063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, please respect the media format and bitrate orders in the list.
A NewPipe support for the added itags is also needed, as they are now whitelisted: see TeamNewPipe/NewPipe#9748.
By the way, this change will probably make the app download these 30k audios instead of the 50k ones for demuxed video streams, when these audio streams are available. This audio selection bug should be definitively fixed before we release a new NewPipe version.
Also use a better branch name in the future, like described in our contribution guidelines.
extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/ItagItem.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, though I am not sure about what average value we should give to the itag 600. Is there someone else which may have more input about that?
This PR will be merged using the squash and merge option.
Please let me know if I should submit another PR to the app to whitelist the new formats now or after merging this one.
I think you will need to do so, but we really need to fix the issue I mentioned on the fly, otherwise the audio quality for demuxed video downloads may be worse than it is already for MPEG-4 streams.
I didn't get an answer on this question, so I will keep the average value as it is.
See TeamNewPipe/NewPipe#10446.
@yshalsager Do you still want to do so or should I do this myself? You simply need to update the extractor commit and, of course, to add 599 and 600 formats to the allowed itags list of NewPipe. I am merging the pull request, thanks for your contribution! |
Sorry, I am on a vacation for a few weeks, would be grateful if you added it.
My pleasure, thanks for your review and awesome efforts! |
While using yt-dlp I noticed that there are two new audio formats for ultra-low connections (599 m4a and 600 webm) which NewPipe doesn't support yet, so I added them.
Here's a screenshot from the build app after these changes, works as expected.
Screenshot