[YouTube] Improve and fix YoutubeJavaScriptExtractor #1087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves and fixes a part of the extraction of YouTube's JavaScript base player file, by doing the following changes:
The breaking changes introduced, which are internal to the extractor (the methods changed were not expected to be used by clients), have been applied where needed, in
YoutubeJavaScriptExtractorTest
andYoutubeStreamExtractor
(in which an unneededinitStsFromPlayerJsIfNeeded
call has been removed).