[PeerTube] Do not accept non-URLs #1143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No NewPipe changes are needed.
This PR makes the PeerTube
onAcceptUrl
methods returnfalse
if the input is not a valid URL.This is done by passing the input to the
URL
constructor and returningfalse
if aMalformedURLException
gets caught.The PeerTube
onAcceptUrl
methods currently only checks whether the input contains path parts like/videos/
or/a/
.This causes problems when they get called when NewPipes
SearchFragment.search
checks whether the users search query is an accepted URL, since non-URL search queries can contain those parts. TeamNewPipe/NewPipe#10695 is caused by the search queryorchestr/a/
being interpreted as a PeerTube Account URL because it contains/a/
.Fixes TeamNewPipe/NewPipe#10695