[MediaCCC] Allow obtaining channel tab link handler #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e. without needing to pass through the conference/channel extractor This was needed because clients (like NewPipe) might rely on link handlers to hold as little data as possible, since they might be kept around for long or passed around in system transactions, so this commit allows obtaining a standalone link handler that does not hold a JsonObject within itself.
This caused problems in NewPipe, because extractors are not serializable, and well, keeping references to them is a bad idea anyway.
5 tasks
|
I guess this is a fix for TeamNewPipe/NewPipe#10714, isn't it? |
|
Probably it is, although the log posted by the user was fixed in your hotfix PR |
|
Ah, I just saw that the user listed 0.26.1 as affected version, but the logs indicate that the crash was happening on 0.26.0... |
TobiGr
approved these changes
Mar 27, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proper fix for TeamNewPipe/NewPipe#10698. Now it is possible to obtain a channel tab link handler, and
nullis never returned. The comments scattered around the code should explain my approach better than I could do in the PR description ;-), but the important point is that I reused the existing channel link handler for channel tabs, too.Fixes
TransactionTooLargeExceptionwhen switching away from NewPipe while there are MediaCCC channels open. Before I could reproduce this consistently, while with this PR the crash is fixed.The fact that the channel and the channel tab have the same url made it so that NewPipe would cache them both under the same key. I opened TeamNewPipe/NewPipe#10717 to fix that, and you can try the APK there to test these changes.