[YouTube] Adjust throttling function extraction to changes #1191
Conversation
|
And boy did I not look at this in forever or even develop anything on my own PC. Getting everything running again was a challenge 😅 |
|
Seeing this here about A/B testing I'm wondering if we still need to support the old format. |
Was your changes based on yt-dlp/yt-dlp#10390? I think they have tests that work even for previous versions of the player code. |
No, it was solely based on #1190 |
|
I don't think should throw out the old extraction function since that may break things for users still getting the old script (or in case they choose to revert these changes). We already use a list of regexes to get the signature decryption function, we should do that for the nsig too. |
|
I can confirm it works. Thank you a lot!
Yeah, I'll work on this rn. |
|
Done, and tested on this APK which works: app-debug.zip @XiangRongLin or @Theta-Dev please look at the code, and if it looks good to you we can proceed with merging and releasing a hotfix. |
...main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeThrottlingParameterUtils.java
Outdated
Show resolved
Hide resolved
* [Youtube] Adjust throttling function extraction to changes --------- Co-authored-by: Stypox <stypox@pm.me>
AudricV
changed the title
Fix: [YT] videos can not be played <NewPipeExtractor TeamNewPipe#1191>
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Using the info from #1190
it should resolve that issue and TeamNewPipe/NewPipe#11255
The YoutubeThrottlingParameterDeobfuscationTest are working again with this. The failing ones are bandcamp
newpipe-debug.zip