-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix YouTube videos with no views #292
Conversation
@wb9688 what happens in other localizations? I would put a check on the result of |
@Stypox: There are multiple places where we use localized strings, e.g. https://github.com/wb9688/NewPipeExtractor/blob/cb57123be199dd1633776e65020fae487692a1f5/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java#L243. @B0pol said he gave up on supporting localized YouTube sites though. |
I know localized YouTube is not correctly supported, but since there is the opportunity not to introduce another dependency on English, let's not do it ;-) |
I've run into the same issue - independently - and fixed this way: #294 |
Updated PR to use same approach as in YoutubeStreamInfoItemExtractor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I agree with @Stypox. However, as we only support content country "en" at the moment, this seems to be okay for now.
@TobiGr oh, I was about to do it, I already added the change to the changelog ;-) |
I added it, too. Maybe I have overridden it 😆 |
Fixes TeamNewPipe/NewPipe#3238