Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update invidious instances #365

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Update invidious instances #365

merged 2 commits into from
Jul 2, 2020

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Jul 2, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

TeamNewPipe/NewPipe#3654 part 1 of 2

@B0pol B0pol mentioned this pull request Jul 2, 2020
Merged
5 tasks
TobiGr
TobiGr approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Should we set up tests to detect if any of these instances is down / removed from the "official" instances list?

@TobiGr TobiGr added this to the 0.19.6 milestone Jul 2, 2020
@B0pol
Copy link
Member Author

B0pol commented Jul 2, 2020 •
edited
Loading

Looks good.
Should we set up tests to detect if any of these instances is down / removed from the "official" instances list?

No, in the extractor the list will be dropped with #352: we will dynamically know if it's an invidious instance by querying the API.
Though the list in manifest must be hardcoded, and I agree we could detect with tests, but not in the extractor.

@TobiGr
Copy link
Member

TobiGr commented Jul 2, 2020

Ah yes, I forgot about #352.

@TobiGr TobiGr merged commit 54d9e5a into TeamNewPipe:dev Jul 2, 2020
@TobiGr TobiGr changed the title Update inv instances Update invidious instances Jul 2, 2020
@B0pol B0pol deleted the update_inv_instances branch July 2, 2020 21:15
This was referenced Jul 11, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
invidious
Projects
None yet
Milestone
0.19.6
Development

Successfully merging this pull request may close these issues.
2 participants
@B0pol @TobiGr