Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YouTube player JavaScript URL redirection #497

Merged
merged 1 commit into from
Dec 27, 2020

Conversation

AudricV
Copy link
Member

@AudricV AudricV commented Dec 24, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe. - I don't think this is required because this PR just fix a redirection.

I noticed when NewPipe gets YouTube's player config, there is always a redirect to www.youtube.com/url_to_js_player from youtube.com/url_to_js_player like in the screenshot below:

YT player config redirect

This PR fixes it by directly request the player config at www.youtube.com instead of youtube.com.

@TobiGr TobiGr added the youtube service, https://www.youtube.com/ label Dec 25, 2020
@TobiGr TobiGr merged commit 3c8c8e7 into TeamNewPipe:dev Dec 27, 2020
@AudricV AudricV deleted the fix-player-js-url-redirect branch December 27, 2020 18:40
@TobiGr TobiGr mentioned this pull request Jan 18, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
youtube service, https://www.youtube.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants