Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gradle 7.1.1 #687

Merged
merged 3 commits into from
Aug 8, 2021
Merged

Upgrade to Gradle 7.1.1 #687

merged 3 commits into from
Aug 8, 2021

Conversation

TacoTheDank
Copy link
Member

  • I carefully read the contribution guidelines and agree to them.
  • [N/A] I have tested the API against NewPipe.
  • [N/A] I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Handles #682, which in turn closes TeamNewPipe/NewPipe#6651.

1st commit

I don't really know what to do about the maven publishing, or if anything needs to be done or added, because this feels too easy. We don't have any existing publishing setup anywhere, so idk.

I updated Gradle to 7.1.1 using git bash.

2nd commit

Saw some things I wanted to improve, so I did that.

@Stypox
Copy link
Member

Stypox commented Jul 21, 2021

I don't really know what to do about the maven publishing, or if anything needs to be done or added, because this feels too easy.

Just check if JitPack works on your latest commit, i.e. implementation "com.github.TacoTheDank:NewPipeExtractor:10f17f37564364de85912024b3a274cedf1143fb"

@TacoTheDank
Copy link
Member Author

@Stypox It, uh, doesn't... https://jitpack.io/com/github/TacoTheDank/NewPipeExtractor/10f17f3756/build.log

I don't work with maven publishing stuff, I have no idea how it works. Someone will probably have to help me out here, as I'm not familiar with the JDoc stuff. I allow commits to forks, so they can be added on to this PR.

@TobiGr
Copy link
Member

TobiGr commented Jul 21, 2021

Here is the jitpack log. The build is successful, however no build artifacts are found.

The interesting part of the logs
BUILD SUCCESSFUL in 6s
10 actionable tasks: 7 executed, 3 up-to-date
Build tool exit code: 0
Looking for artifacts...
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Dhttps.protocols=TLSv1.2
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Dhttps.protocols=TLSv1.2
Looking for pom.xml in build directory and ~/.m2
2021-07-21T15:29:48.830579556Z
Exit code: 0

ERROR: No build artifacts found

For comparison, here is the NewPipe Extractor 0.21.6 log

@TacoTheDank
Copy link
Member Author

TacoTheDank commented Jul 21, 2021

I have an idea actually that involves artifact naming schemes. However, I have to go to work now, so I'll try it out when I get back.

@TacoTheDank
Copy link
Member Author

Ok so it didn't work. Nevermind.

@litetex
Copy link
Member

litetex commented Aug 3, 2021

@TacoTheDank
Copy link
Member Author

@litetex Getting

A problem occurred configuring project ':extractor'.
> Could not get unknown property 'release' for SoftwareComponentInternal set of type org.gradle.api.internal.component.DefaultSoftwareComponentContainer.

when trying those solutions...

@litetex
Copy link
Member

litetex commented Aug 6, 2021

@TacoTheDank

I could fix it using litetex@654857a
Jitpack-log: https://jitpack.io/com/github/litetex/NewPipeExtractor/654857a62d4fb572d18dacb6f4ee0d47b920aeac/build.log

https://stackoverflow.com/a/42977330 did the trick

@TacoTheDank
Copy link
Member Author

@litetex Bless you :P

@TacoTheDank
Copy link
Member Author

Rebased on upstream.

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TacoTheDank & @litetex

@TobiGr TobiGr merged commit 78f2192 into TeamNewPipe:dev Aug 8, 2021
@TacoTheDank TacoTheDank deleted the gradle7 branch August 8, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using local extractor fails due to different gradle major version
4 participants