-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Gradle 7.1.1 #687
Conversation
Just check if JitPack works on your latest commit, i.e. |
@Stypox It, uh, doesn't... https://jitpack.io/com/github/TacoTheDank/NewPipeExtractor/10f17f3756/build.log I don't work with maven publishing stuff, I have no idea how it works. Someone will probably have to help me out here, as I'm not familiar with the JDoc stuff. I allow commits to forks, so they can be added on to this PR. |
Here is the jitpack log. The build is successful, however no build artifacts are found. The interesting part of the logs
For comparison, here is the NewPipe Extractor 0.21.6 log |
I have an idea actually that involves artifact naming schemes. However, I have to go to work now, so I'll try it out when I get back. |
Ok so it didn't work. Nevermind. |
I don't know if this helps but I found: |
@litetex Getting
when trying those solutions... |
I could fix it using litetex@654857a https://stackoverflow.com/a/42977330 did the trick |
@litetex Bless you :P |
Rebased on upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @TacoTheDank & @litetex
Handles #682, which in turn closes TeamNewPipe/NewPipe#6651.
1st commit
I don't really know what to do about the maven publishing, or if anything needs to be done or added, because this feels too easy. We don't have any existing publishing setup anywhere, so idk.
I updated Gradle to 7.1.1 using git bash.
2nd commit
Saw some things I wanted to improve, so I did that.