Fix some warnings and in Bandcamp use Java 8 streams #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, basically where the overriding function was missing an annotation from the base method. Also apply renaming of emptyDescription to EMPTY_DESCRIPTION
litetex
requested changes
Mar 27, 2022
.../java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampSearchExtractor.java
Show resolved
Hide resolved
.../java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampSearchExtractor.java
Outdated
Show resolved
Hide resolved
.../java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampStreamExtractor.java
Outdated
Show resolved
Hide resolved
Stypox
changed the title
Stypox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing the checkstyle PR I found some more things that could be improved. This PR tries to use Java 8 streams in the bandcamp extractor (which should, among other things, improve resiliency), and fixes some other warnings here and there as reported by Android Studio. Check the commits for more info.
Btw if you leave comments/reviews don't expect me to answer until a few days/weeks ;-)