-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused methods #846
Conversation
@litetex You should have checked with more caution because they are still used by NewPipe on the
This PR should be reverted in my opinion. |
@AudricV A fix is provided with TeamNewPipe/NewPipe#8531 |
I am a little late on this. Can you please clarify why you removed the methods? |
I think people can handle removal of 2 barely used methods. Especially when the complete extractor architecture was/will be reworked with #810 and #862. Also there was no prior warning when the behavior of returning null was changed to throwing a exception.
I moved the method into the app, because a) it's used there and b) the new method doesn't have a use the unnecessary |
After working on TeamNewPipe/NewPipe#7458 I noticed that these methods (and corresponding tests) are no longer required and can be removed.
This PR can be merged once TeamNewPipe/NewPipe#7458 is done