Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use minimum required permissions for GitHub workflows #869

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Use minimum required permissions for GitHub workflows #869

merged 1 commit into from
Jul 13, 2022

Conversation

triallax
Copy link
Contributor

@triallax triallax commented Jul 3, 2022 •
edited by opusforlife2
Loading

This reduces the attack surface if the workflows are ever compromised.

@triallax
Use minimum required permissions for GitHub workflows
414186c 
This reduces the attack surface if the workflows are ever compromised.
@triallax triallax added the CI Everything related to CI (Continuous integration) label Jul 3, 2022
litetex
litetex approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@litetex litetex mentioned this pull request Jul 10, 2022
Merged
2 tasks
Stypox
Stypox approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have manually specified permissions for each workflow, I made the default permissions read-only. Let's see if this works correctly...
image

@Stypox Stypox merged commit 8c5f014 into TeamNewPipe:dev Jul 13, 2022
@triallax triallax deleted the add-workflow-permissions branch July 13, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex approved these changes

@Stypox Stypox Stypox approved these changes

@TheAssassin TheAssassin TheAssassin approved these changes

Assignees
No one assigned
Labels
CI Everything related to CI (Continuous integration)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@triallax @TheAssassin @Stypox @litetex