Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Rhino since it uses a class not available on Android #912

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Aug 25, 2022

Reverts #774
Fixes TeamNewPipe/NewPipe#8876
See mozilla/rhino#1149 for why this is needed

@Stypox Stypox merged commit 6a85836 into TeamNewPipe:dev Aug 25, 2022
@Stypox
Copy link
Member Author

Stypox commented Aug 25, 2022

I tested and it actually works

@leslie-alldridge

This comment was marked as off-topic.

@Theta-Dev
Copy link
Contributor

I have already made a debug build which includes thia fix as well as a JS extractor change

https://github.com/TeamNewPipe/NewPipe/files/9387795/app-debug.zip

@nontekkie
Copy link

I am not a developer (far from it), but I came here because my NewPipe app keeps breaking. Is the link above (https://github.com/TeamNewPipe/NewPipe/files/9387795/app-debug.zip) the fix I need if videos load infinitely? If so, once I download it, do I have to perform more steps, or will the download automatically modify my app? Thanks

@Theta-Dev
Copy link
Contributor

just get the officiel 0.23.3 release

@nontekkie
Copy link

nontekkie commented Aug 30, 2022 via email

@leslie-alldridge
Copy link

Lol your setup sounds overly complicated. Don't bother with an app store just download directly from their website. If that doesn't work you need to allow apps from unknown sources. If that fails, I doubt there's a terracube custom os specialist so you're probably on ya own

@TeamNewPipe TeamNewPipe locked as off-topic and limited conversation to collaborators Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIXED IN 0.23.3] [YouTube] Videos and descriptions not loading
5 participants