[YouTube] Fix fallback throttling decryption function regex #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Quote the function name, as it may contain special regex symbols, such as dollar; - Support multiple lines; - Use what looks like the end of the function for the end of the regex (this part is inspired from yt-dlp throttling parameter decryption regex); - Move the throttling function body regex into a private and static constant.
…e pattern Use the same possible characters for variables everywhere, in order to avoid potential future throttling parameter decryption function name parsing issues related to the usage of other letter(s) than b.
AudricV
added
bug
Stypox
approved these changes
Sep 25, 2022
Stypox
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the regex used to get the throttling decryption function code, utilized as a fallback when the lexer fails to parse the function (this should not happen). To do so, the following changes have been made to the regex:
I also made changes on the function used to get the variable representing an array containing the throttling parameter decryption function, which doesn't rely on a specific letter anymore (
b), but on alphanumeric characters instead (+$and_) (this change has been applied on all the regex).