[YouTube] Support handles and all channel usernames #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
added
bug
AudricV
force-pushed
the
yt-support-handles-and-all-channel-usernames
branch
from
b4c3d3d
to
396d1d9
Compare
More non-channel paths have been also added to the excluded custom name paths, documentation and exception messages have been improved and fixed in some places, and the licence header of YoutubeChannelLinkHandlerFactory has been moved to its beginning and updated.
…s support Unneeded public modifiers in test methods of YoutubeChannelLinkHandlerFactoryTest have been also removed.
AudricV
force-pushed
the
yt-support-handles-and-all-channel-usernames
branch
from
396d1d9
to
20cd8e8
Compare
AudricV
commented
Nov 3, 2022
| } | ||
|
|
||
| final String id = splitPath[1]; | ||
|
|
||
| if (id == null || !id.matches("[A-Za-z0-9_-]+")) { | ||
| throw new ParsingException("The given id is not a Youtube-Video-ID"); | ||
| if (isBlank(id)) { |
There was a problem hiding this comment.
Do you think we should use something else to match all custom names of channels or not?
There was a problem hiding this comment.
Is it possible to have a channel ID that does not match the old pattern, e.g. by consisting of non latin characters?
There was a problem hiding this comment.
Ok. dumb question. you put one into your tests... https://www.youtube.com/c/%EB%85%B8%EB%A7%88%EB%93%9C%EC%BD%94%EB%8D%94NomadCoders
TobiGr
approved these changes
Nov 4, 2022
|
Merging this PR now, as we could always improve this later, and a few more changes in the parsing logic are needed to fix #965 on the fly. |
This was referenced Nov 4, 2022
6 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support of YouTube handles into the extractor, and supports all user IDs instead of only the ones which match this regular expression.
Furthermore, in this PR, I added more non-channels endpoints to the list of excluded endpoints, improved and fixed documentation, comments and exception messages of
YoutubeChannelLinkHandlerFactory, and moved its license header, updated on the fly, at its beginning.Finally, I added new tests for handles and for a channel which have characters which doesn't match the regular expression linked above, and removed the unneeded
publictest modifiers forYoutubeChannelLinkHandlerFactoryTest.I also make use of a handle for resolving the Gronkh channel ID instead of its custom name, and updated the mocks of this test, as it was needed.
Fixes #875 and TeamNewPipe/NewPipe#9243 for the extractor implementation.