Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SoundCloud] Implement getUploaderUrl() and isUploaderVerified() for PlaylistInfoItemExtractor #995

Merged
merged 1 commit into from
Jan 2, 2023
Merged

[SoundCloud] Implement getUploaderUrl() and isUploaderVerified() for PlaylistInfoItemExtractor #995

merged 1 commit into from
Jan 2, 2023

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Dec 4, 2022

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Closes #961

@TobiGr TobiGr added the soundcloud service, https://soundcloud.com/ label Dec 4, 2022
@opusforlife2
Copy link
Collaborator

Why close the issue? Are YT and SC the only services where this matters?

@TobiGr
Copy link
Member Author

TobiGr commented Dec 6, 2022

I should have added that the other services don't support this. I looked into it, but the info is not provided

AudricV
AudricV requested changes Dec 31, 2022
View reviewed changes
Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the USER_KEY constant instead of duplicating its value.

@TobiGr TobiGr force-pushed the feat/soundcloud-playlistinfoitemextractor branch from 8470b9a to 292e0d8 Compare December 31, 2022 17:46
@Stypox Stypox merged commit 259de3c into dev Jan 2, 2023
@opusforlife2 opusforlife2 deleted the feat/soundcloud-playlistinfoitemextractor branch January 2, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AudricV AudricV AudricV approved these changes

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
soundcloud service, https://soundcloud.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement uploaderUrl() and uploaderVerified() for PlaylistInfoItem in SoundCloud
4 participants
@TobiGr @opusforlife2 @Stypox @AudricV