[fix] 기타 수정사항 적용 #85 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkjyun
approved these changes
Jan 15, 2024
Comment on lines
+51
to
+57
| @ExceptionHandler(value = {MissingServletRequestParameterException.class}) | ||
| public ResponseEntity<ApiResponse<?>> handlerMissingServletRequestParameterException(Exception e) { | ||
| log.error("handlerMissingServletRequestParameterException() in GlobalExceptionHandler throw MissingServletRequestParameterException : {}", e.getMessage()); | ||
| return ResponseEntity.status(HttpStatus.BAD_REQUEST) | ||
| .body(ApiResponse.fail(ErrorMessage.MISSING_REQUIRED_PARAMETER)); | ||
| } | ||
|
|
There was a problem hiding this comment.
http code를 이제 responsebodyadvice에서 처리해서 나중에 한꺼번에 리팩토링 하면 좋을 것 같아요
| @@ -69,7 +85,7 @@ public ResponseEntity<ApiResponse<?>> handleCustomException(CustomException e) { | |||
|
|
|||
| @ExceptionHandler(Exception.class) | |||
| public ResponseEntity<ApiResponse<?>> handlerException(Exception e) { | |||
| log.error("handlerException() in GlobalExceptionHandler throw Exception : {}", e.getMessage()); | |||
| log.error("handlerException() in GlobalExceptionHandler throw Exception : {} {}", e.getClass(), e.getMessage()); | |||
There was a problem hiding this comment.
exception 다 잡을 때까지 이렇게 e.getClass() 해 놓는 것 좋은 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 📌
Description ✔️