Allow material-ui 0.17.x in peerDependencies and add yarn.lock #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sibartlett
reviewed
Apr 3, 2017
package.json
Outdated
| @@ -40,7 +40,7 @@ | |||
| "react-tap-event-plugin": "^2.0.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "material-ui": "~0.16.7", | |||
| "material-ui": ">=0.16 <=0.17", | |||
There was a problem hiding this comment.
Why not do the following? ^0.16
I don't see a reason to limit the peer dependency to a fixed range, unless someone reports an issue.
There was a problem hiding this comment.
Yea I think we should do that too then.
There was a problem hiding this comment.
@hhaidar Feel free to change it. 👍 The current version should work on every recent 0.x version.
Add yarn.lock
|
This looks good to merge :) |
|
Published as v1.1.2. 🚒 |
|
Thanks, much appreciated @leMaik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using material-ui v0.17 and this component works well with it!