Boat #348
Draft
Boat #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Pelotrio
commented
Jun 29, 2022
Pelotrio
commented
- Generates a boat in the underworld dimension
- Boat spawns with enemies and loot
- Special loot includes the ancient pearl
Took 15 minutes Took 3 minutes
Took 3 hours 30 minutes
|
|
murapix
requested changes
Jun 29, 2022
| @@ -20,6 +20,9 @@ public class PacketThriveBlock extends PacketBase { | |||
| @Save | |||
| public BlockPos pos; | |||
|
|
|||
| public PacketThriveBlock() { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This should not have an empty constructor
| PlacementSettings placementsettings = new PlacementSettings(); | ||
| Rotation rotation = Rotation.values()[rand.nextInt(Rotation.values().length)]; | ||
| placementsettings.setIgnoreEntities(false).setMirror(Mirror.NONE).setRotation(rotation); | ||
| underworld_boat.addBlocksToWorld(world, position, placementsettings); |
There was a problem hiding this comment.
Use camelCase for all these variables
Took 1 hour 4 minutes
Took 2 minutes
|
|
Took 1 hour 19 minutes
|
|
Took 1 hour 33 minutes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.