Creating a more robust nvm-purge. #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prep for future functionality to upgrade
nvm/nodeversions in the future, or upgrade when runningFluxNodeInstallagainst a previously non-ansible managed FluxNode (node started withmultitoolboxonly).This pull request introduces changes to the roles and tasks related to the daemon and nvm. The most important changes include the addition of new tasks for starting and stopping the daemon service, modifications to the nvm installation task to install a specific version of Node, and the addition of tasks to stop Flux via PM2 and stop the Daemon.
Summary of changes:
roles/daemon/tasks/main.yml: Added two new tasks, "Start Daemon Service" and "Stop Daemon Service", which include tasks from separate files.roles/daemon/tasks/daemon-start.yml: Added a new task named "Ensure Scripts Exist" which includes tasks from thedaemon-scripts.ymlfile.roles/daemon/tasks/daemon-stop.yml: Added a new task named "Ensure Scripts Exist" which includes tasks from thedaemon-scripts.ymlfile.roles/nvm/tasks/nvm-install.yml: Modified the task to install a specific version of Node using nvm.roles/nvm/tasks/nvm-purge.yml: Added two new tasks to stop Flux via PM2 and stop the Daemon.