Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Docker Debug Log from logrotate #78

Merged
merged 4 commits into from
Mar 3, 2024
Merged

Conversation

JKTUNING
Copy link
Collaborator

@JKTUNING JKTUNING commented Jan 3, 2024

Remove unused log rotate for Docker Debug log.

@JKTUNING JKTUNING requested a review from TechDufus January 3, 2024 13:35
Copy link
Owner

@TechDufus TechDufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ship it

Copy link
Owner

@TechDufus TechDufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On 2nd thought, this won't actually purge the rule that already exists that this has already created on nodes.

- Purge legacy log rotate items
@JKTUNING
Copy link
Collaborator Author

JKTUNING commented Jan 3, 2024

@TechDufus adding legacy files/folders to check during purge. Including update to vars file.

@TechDufus
Copy link
Owner

@TechDufus adding legacy files/folders to check during purge. Including update to vars file.

This will only be 'cleaned up' if a purge is ran though, correct?

@JKTUNING
Copy link
Collaborator Author

JKTUNING commented Jan 3, 2024

@TechDufus adding legacy files/folders to check during purge. Including update to vars file.

This will only be 'cleaned up' if a purge is ran though, correct?

Yes, I suppose we can just tack a remove at the end of the install to ensure any "Legacy" files are cleaned up/removed.

- Ensure old "legacy" entries are removed during install
- Add task to "clean" Log Rotate legacy entries
- Allows this to be called separate of install and purge
- logrotate-clean tag added
@TechDufus TechDufus merged commit 7cc6e25 into main Mar 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants