Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to clone modpacks entirely. #470

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Commits on Sep 24, 2015

  1. Added the ability to clone modpacks entirely. Addresses TechnicPack#71

    - Added a link in the sidebar to clone a modpack.
    - Cloning to an existing modpack will overwrite it with the source's packs.
    - Cloning to a nonexistent pack will create it.
    
    Some concerns:
    - There are no permissions associated with cloning.
    - Destination list is loaded via JS therefore the modpacks have to be public even if the user has access to them.
    - No modpack permissions are considered before handling cloning to/from anything.
    EntranceJew committed Sep 24, 2015
    Configuration menu
    Copy the full SHA
    6905056 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2015

  1. Added better cloning logic and fixed the UI.

    - Clone inputs are validated and required.
    - Fixed issue where min_memory wasn't actually being copied.
    - Fixed issue where cloned builds weren't also cloning modversions.
    - Removed using AJAX to get the list of destinations.
    - Added validation condition to ensure cloning to the same modpack doesn't happen.
    - Removed the ability to create entries for the source selector. (This was meant for debugging only.)
    EntranceJew committed Sep 30, 2015
    Configuration menu
    Copy the full SHA
    d15c0c0 View commit details
    Browse the repository at this point in the history