Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.17.x and bump version #40

Open
wants to merge 1 commit into
base: 1.16-Fabric
Choose a base branch
from

Conversation

cm-360
Copy link

@cm-360 cm-360 commented Jul 25, 2021

Unofficial update to 1.17.x, there is also no 1.17-Fabric branch on the base repository and I used 1.16-Fabric as a starting point so I figured it was the best place to point this PR.

@FracturedCode
Copy link

I was able to build and run with this fork. The author seems to be MIA. I would start maintaining a fork and distributing it myself, but I think that would trample on the "All Rights Reserved" license.

@TechnicianLP
Copy link
Owner

I was able to build and run with this fork. The author seems to be MIA. I would start maintaining a fork and distributing it myself, but I think that would trample on the "All Rights Reserved" license.

The license does indeed not allow you to redistribute a fork - which in turn also causes legal issues with accepting PRs (which i have yet to work out)

@srnyx
Copy link

srnyx commented Aug 29, 2021

How can I build this?

@FracturedCode
Copy link

FracturedCode commented Sep 1, 2021

How can I build this?

checkout cm-360's 1.17-Fabric branch, open the build.gradle "as project" in intellij, then run the build gradle task. You might have to adjust your compile settings for Java 16. This can be changed in Project Structure and Gradle settings UIs.
The binaries can be found under the build/libs folder or something like that.

@FracturedCode
Copy link

FracturedCode commented Sep 1, 2021

I was able to build and run with this fork. The author seems to be MIA. I would start maintaining a fork and distributing it myself, but I think that would trample on the "All Rights Reserved" license.

The license does indeed not allow you to redistribute a fork - which in turn also causes legal issues with accepting PRs (which i have yet to work out)

Obviously it is within your right to keep this project under "All Rights Reserved", but I think the easiest way to sort this out would probably be to relicense under MIT or LGPLv3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants