Week 5: Chatbot #278
Open
Week 5: Chatbot #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Good job putting together this project and making it "your own" 💪 Let's dive into each part of your code...
HTML/CSS
- Very nice styling, it feels cohesive throughout 🎨
- You didn't change the HTML starter code too much, so not too much to say about that. Descriptive class names 👍
JavaScript
- Nice addition with the sound! 🔈 Consider making it into a reusable function called playAudio
- Nice structure of your DOM selectors and global variables
- Remember that you have the power to do anything you want, such as emptying the inputWrapper right after the user has made their choice. Would be nice for user experience I think 😇
Clean Code
- Most variable names are descriptive and follow camelCase, which is great for readability. 🎉 Some of them I think could be even more descriptive. Take askDream, dreamSuperpowers and dreamSuper as examples. Maybe they could be renamed to "askForDreamSuperpower", "showSuperpowerOptions" and "handleSuperpowerAnswer". NB: Just a suggestion, but for coming projects, challenge yourself to make your code completely selfdescribing and ask yourself "Can someone figure out what this function does, just by reading the function name?".
- The JavaScript code is generally well-formatted with consistent indentation. This makes the code easy to follow. One small note: ensure there is a consistent use of spacing around operators and statements for clarity.
Really nice job and well thought through flow ⭐
Comment on lines
+14
to
+20
| <div class="left-side"> <!-- Added to sides to the website to make it easier to style it in the CSS--> | ||
| <header> | ||
| <h1>WELCOME TO YOUR BOREDOM BUDDY BOT!</h1> | ||
| <p>I'm here to help you find a company on this boring day!</p> | ||
| </header> | ||
| <img src="assets/chatbot.png" alt="Fitness Buddy Bot" class="bot-image" /> | ||
| </div> |
|
Thank you @HIPPIEKICK for this feedback! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my chatbot for the week 5 project
Netifly link: https://boredombot.netlify.app/