Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xings chatbot about travel adventure #281

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xingyin2024
Copy link

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with your travel chatbot ✈️ Let's have a look at some feedback!

HTML/CSS

  • Clean structure and nicely styled 👍 Just be mindful when using text overlay on images, the text is barely readable

JavaScript

  • Various functions handle different aspects of the conversation, such as showing messages, asking questions, and processing user inputs. This modular approach is excellent for readability and reusability ⭐
  • Nice with some sound, makes it more interactive! Consider breaking it out into its own function
  • LOVE the renderOptions function! Way to make it DRY 🥳
  • Consider adding some validation so that the user can't submit an empty name input

Clean Code

  • Your descriptive function names really helps with the readability, keep going like this! ⭐
  • Remember curly brackets for if/else statements, it makes the code easier to read

Keep up the good work Xing, looking good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants