Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mikas chatbot #291

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Mikas chatbot #291

wants to merge 5 commits into from

Conversation

mikaeber
Copy link

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job putting together this bot 💯 Let's go through some feedback.

JavaScript

  • Nice usage of switch and clever idea with the numberOfFormSubmits 👍
  • Nice flow overall, just make sure to update the text (or the options) so that they correspond 🍕
    Skärmavbild 2024-09-19 kl  16 33 00

Clean Code

  • Overall, you're code is clean and you're following JS naming conventions. Just a tiny idea, to change orderConfirmation to confirmOrder, to follow the same naming pattern as your other functions (e.g. clearForm -> verbNoun)

Quite advanced but still readable code - it's easy to follow, so kudos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants