fix(deep-assign): add deepAssign to objects in strategy create's

package.json

@@ -52,6 +52,7 @@
     ]
   },
   "dependencies": {
+    "deep-assign": "^2.0.0",
     "halcyon": "^0.19.1"
   }
 }

src/plugins/array.js

@@ -1,3 +1,4 @@
+const deepAssign = require('deep-assign')
 const { without } = require('halcyon')
 
 module.exports = {
@@ -30,7 +31,9 @@ module.exports = {
     if (mods.remove && !Array.isArray(mods.remove)) throw new Error(`Remove property must be an array`)
     mods.add = mods.add || []
     mods.remove = mods.remove || []
+    // Deep assign nested objects
+    const assign = (arr) => arr.map((x) => typeof x === 'object' ? deepAssign({}, x) : x)
     // Apply modifications and return
-    return without(mods.remove, [ ...data ]).concat([ ...mods.add ])
+    return without(mods.remove, [ ...assign(data) ]).concat([ ...assign(mods.add) ])
   }
 }

src/plugins/json.js

@@ -1,3 +1,5 @@
+const deepAssign = require('deep-assign')
+
 module.exports = {
   /**
    * @property {String} plugin name
@@ -24,6 +26,6 @@ module.exports = {
    */
   create: (data, mods = {}) => {
     if (typeof mods !== 'object') throw new Error(`Must supply a valid object`)
-    return JSON.stringify(Object.assign({}, data, mods))
+    return JSON.stringify(deepAssign({}, data, mods))
   }
 }

src/plugins/object.js

@@ -1,3 +1,5 @@
+const deepAssign = require('deep-assign')
+
 module.exports = {
   /**
    * @property {String} plugin name
@@ -21,6 +23,6 @@ module.exports = {
    */
   create: (data, mods = {}) => {
     if (typeof mods !== 'object') throw new Error(`Must supply a valid object`)
-    return Object.assign({}, data, mods)
+    return deepAssign({}, data, mods)
   }
 }

test/src/plugins/array.spec.js

@@ -17,13 +17,13 @@ describe('plugins/array', () => {
   })
   describe('create', () => {
     it('returns a new instance of the array with mods applied', () => {
-      const original = [ 'foo', 'bar' ]
+      const original = [ 'foo', { fizz: 'buzz' }, 'bar' ]
       const actual = array.create(original, {
         add: [ 'baz' ],
         remove: [ 'bar' ]
       })
-      expect(original).to.deep.equal([ 'foo', 'bar' ])
-      expect(actual).to.deep.equal([ 'foo', 'baz' ])
+      expect(original).to.deep.equal([ 'foo', { fizz: 'buzz' }, 'bar' ])
+      expect(actual).to.deep.equal([ 'foo', { fizz: 'buzz' }, 'baz' ])
     })
     it('throws if mods argument is not an object', () => {
       expect(() => array.create([ 'foo' ], 'bar')).to.throw(/Must supply a valid object/)

yarn.lock

@@ -242,6 +242,12 @@ decamelize@^1.0.0:
   version "1.2.0"
   resolved "https://registry.yarnpkg.com/decamelize/-/decamelize-1.2.0.tgz#f6534d15148269b20352e7bee26f501f9a191290"
 
+deep-assign@^2.0.0:
+  version "2.0.0"
+  resolved "https://registry.yarnpkg.com/deep-assign/-/deep-assign-2.0.0.tgz#ebe06b1f07f08dae597620e3dd1622f371a1c572"
+  dependencies:
+    is-obj "^1.0.0"
+
 deep-eql@^0.1.3:
   version "0.1.3"
   resolved "https://registry.yarnpkg.com/deep-eql/-/deep-eql-0.1.3.tgz#ef558acab8de25206cd713906d74e56930eb69f2"
@@ -794,6 +800,10 @@ is-my-json-valid@^2.10.0:
     jsonpointer "^4.0.0"
     xtend "^4.0.0"
 
+is-obj@^1.0.0:
+  version "1.0.1"
+  resolved "https://registry.yarnpkg.com/is-obj/-/is-obj-1.0.1.tgz#3e4729ac1f5fde025cd7d83a896dab9f4f67db0f"
+
 is-path-cwd@^1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/is-path-cwd/-/is-path-cwd-1.0.0.tgz#d225ec23132e89edd38fda767472e62e65f1106d"