#16: 🐛 fix forked session issues with manual action notifications… #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
...-mda/src/main/java/org/technologybrewery/fermenter/mda/notification/NotificationService.java
Outdated
Show resolved
Hide resolved
d-ryan-ashcraft
commented
Jun 21, 2023
...-mda/src/main/java/org/technologybrewery/fermenter/mda/notification/NotificationService.java
Outdated
Show resolved
Hide resolved
...-mda/src/main/java/org/technologybrewery/fermenter/mda/notification/NotificationService.java
Outdated
Show resolved
Hide resolved
| File outputFile = new File(projectParentFile, fileName + "-" + i++ + ".txt"); | ||
| try { | ||
| FileUtils.forceMkdir(projectParentFile); | ||
| FileUtils.write(outputFile, subMapEntry.getValue().getNotificationAsString(), Charset.defaultCharset()); |
There was a problem hiding this comment.
A: Minor, but java.nio.Files can do both of these things without a 3rd party lib.
There was a problem hiding this comment.
Fair, though this library is already there, so feels like 6 and one half
| } | ||
| } | ||
|
|
||
| if (manualActionCount > 0) { |
There was a problem hiding this comment.
A: We are baking in the notion that "notifications" == "manual actions". Maybe/probably fine for incremental addition, but I could see this being more universal, e.g. profile deprecation notifications.
There was a problem hiding this comment.
Yeah - agree. Debated this but didn't have a good example of what wouldn't be a manual action that we are outputting. Easy to refactor to a more general concept if we want to, however.
...-mda/src/main/java/org/technologybrewery/fermenter/mda/notification/NotificationService.java
Outdated
Show resolved
Hide resolved
ewilkins-csi
approved these changes
Jun 21, 2023
d-ryan-ashcraft
force-pushed
the
16-fix-forked-manual-actions
branch
from
cd08667
to
5f9c61b
Compare
…ite notifications and then read them rather than passing around in the Maven Session; with PR feedback
d-ryan-ashcraft
force-pushed
the
16-fix-forked-manual-actions
branch
from
5f9c61b
to
8d8e980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…; write notifications and then read them rather than passing around in the Maven Session