feat: add list view prototype #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TejasQ
requested changes
Sep 18, 2020
TejasQ
requested changes
Sep 22, 2020
| @@ -0,0 +1,21 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
Normally, we don't need to do this. This should work just fine.
Suggested change
| import * as React from 'react'; | |
| import React from 'react'; |
There was a problem hiding this comment.
I had someone point this out to me once: facebook/react#18102
components/BookCard.tsx
Outdated
| import * as React from 'react'; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-empty-interface | ||
| interface BookCardProps {} |
There was a problem hiding this comment.
Let's remove this and add it once we need it. No premature code please.
Also, let's use types over interfaces.
Interfaces have stung me in the past in multiple ways. For example:
- You can declare the same
interfacemultiple times and TS will just go with it and create some weird intersection. Alltypenames are expected to be unique like variables. - Interfaces are more common with OOP (
class Thing implements MyInterface). I'd like this project to be more functional than object-oriented. - Interfaces and types are composable the same way, but types have unique constraints.
- VS Code only: when hovering on a type, you get a FULL DESCRIPTION of its schema. When hovering on an interface, you just see
interface MyInterfacewithout any idea what it actually is.
There was a problem hiding this comment.
We should add this to a wiki page, just in case :)
| @@ -0,0 +1,77 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
See previous comment about the imports.
TejasQ
approved these changes
Oct 1, 2020
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a list view to the main page.