Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/Estonian-*: VAT 20% since 01.07.2009, drop non-utf8 #32

Open
wants to merge 1 commit into
base: full
Choose a base branch
from

Conversation

lkraav
Copy link

@lkraav lkraav commented Feb 24, 2019

There seem to be other countries duplicate templates as well, where the only difference is - vs _ character in the filename (since upstream 3.2.1 merge), but that's too much busywork right now.

@Tekki
Copy link
Owner

Tekki commented Feb 25, 2019

I wouldn't delete files that are part of the DWS code, otherwise I can't merge the code anymore if we get changes from there.
Some of the SQL scripts with '_' seem to be duplicates, but not all (cf. Italian). I'll take a look at it.
In principle it would be enough to have one file with the correct SET CLIENT_ENCODING TO at the beginning.

@lkraav
Copy link
Author

lkraav commented Feb 25, 2019

All clear. Do you post on DWS forums at all to push changes upstream?

@Tekki
Copy link
Owner

Tekki commented Feb 25, 2019

The relation between this code and the one from DWS is described at the bottom of the README.

Copy link
Owner

@Tekki Tekki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files from DWS should not be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants