Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANDROID-13606 - Unify Ids Tags #287

Draft
wants to merge 1 commit into
base: feature_branch/unify_ids
Choose a base branch
from

Conversation

DevPabloGarcia
Copy link
Contributor

🥅 What's the goal?

Unify Ids Tags

Old tag view was a TextView, so we could not reach icon the ID, to solve this problem we wrap compose tag element in XML

🚧 How do we do it?

  • Wrap tag compose element
  • Set new Ids

☑️ Checks

  • I updated the documentation, including readmes and wikis. If this is a breaking change, update UPGRADING.md to inform users how to proceed. If no updates are necessary, indicate so.
  • Tested with dark mode.
  • Tested with API 23.

🧪 How can I test this?

If it cannot be tested explain why.

  • 🖼️ Screenshots/Videos
  • Mistica App QR or download link
  • Reviewed by Mistica design team
  • ...

@github-actions
Copy link

📱 New catalog for testing generated: Download

@DevPabloGarcia DevPabloGarcia changed the title ANDROID-13605 - Unify Ids Tags ANDROID-13606 - Unify Ids Tags Jul 31, 2023
@DevPabloGarcia DevPabloGarcia marked this pull request as draft November 7, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant