APPS-7260 Add option to support the three types of assets defined by design #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeslat
commented
Nov 27, 2020
Comment on lines
-57
to
+65
| attribute = "listRowIsBoxed", | ||
| method = "setBoxed" | ||
| attribute = "listRowAssetType", | ||
| method = "setAssetType" | ||
| ), | ||
| BindingMethod( | ||
| type = ListRowView::class, | ||
| attribute = "listRowHasSmallAsset", | ||
| method = "setSmallAsset" | ||
| attribute = "listRowIsBoxed", | ||
| method = "setBoxed" |
There was a problem hiding this comment.
The diff is a bit weird because I've changed the order but the result is that I've removed listRowHasSmallAsset and added listRowAssetType
dpastor
reviewed
Nov 30, 2020
| private fun getAssetResource(withAsset: Boolean, withAssetType: Int): Int? = | ||
| if (withAsset) { | ||
| if (withAssetType == TYPE_IMAGE) { | ||
| R.drawable.netflix_logo |
There was a problem hiding this comment.
Minor detail. But maybe we can use a simple vector asset here? Just to avoid the 13kb of it :)
There was a problem hiding this comment.
I can use highlighted_card_custom_background.png which is already in the catalog.
dpastor
reviewed
Nov 30, 2020
| android:layout_gravity="center" | ||
| android:scaleType="centerCrop" | ||
| android:visibility="gone" | ||
| app:shapeAppearance="@style/CircleImageView" |
There was a problem hiding this comment.
Awesome!! 😄 Really nice job!!
dpastor
approved these changes
Nov 30, 2020
| 1.0.8 |
There was a problem hiding this comment.
You don't need to commit this (but there is no problem if you do it), the action will commit the version you set automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here you can see the definition https://app.zeplin.io/project/5d653c69f828bf7299c551c1/screen/5f7eed32afc7924fc7b12432/
I've removed the
listRowHasSmallAssetattribute and added a newlistRowAssetTypewhich supports three types:You can see here the result: