ANDROID-15138 Search Input in compose #380
Conversation
|
📱 New catalog for testing generated: Download |
| }, | ||
| trailingIcon = { | ||
| IconButton(onClick = { | ||
| onValueChange("") |
There was a problem hiding this comment.
if user clicks here, we reset the entered text by invoking onValueChange lambda with an empty string
yamal-alm
requested review from
a team,
dpastor,
jeprubio and
AnaMontes11
and removed request for
a team
library/src/main/java/com/telefonica/mistica/compose/input/SearchInput.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/telefonica/mistica/compose/input/SearchInput.kt
Show resolved
Hide resolved
|
📱 New catalog for testing generated: Download |
library/src/test/java/com/telefonica/mistica/compose/input/SearchInputTest.kt
Outdated
Show resolved
Hide resolved
|
📱 New catalog for testing generated: Download |
| android:viewportHeight="24"> | ||
| <path | ||
| android:pathData="M16.841,17.853a0.722,0.722 0,0 0,0.948 -1.086L13.022,12l4.766,-4.767 0.065,-0.074a0.722,0.722 0,0 0,-1.086 -0.947L12,10.978 7.233,6.211l-0.074,-0.064a0.722,0.722 0,0 0,-0.947 1.086L10.979,12 6.21,16.767l-0.064,0.074a0.722,0.722 0,0 0,1.086 0.947L12,13.022l4.767,4.767z" | ||
| android:fillColor="#000000"/> |
There was a problem hiding this comment.
generated screenshots doesn't render these two icons, I guess it is because I was using theme attributes and the roborazzi test doesn't set any xml theme before rendering the composable. I'm using a hardcoded color just to verify that that is the problem
There was a problem hiding this comment.
yes, it seems that the problem is that we are not setting any xml theme during roborazzi test and these type of attributes are not resolved.
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
|
Hi @yamal-alm, could we add the helper text? |
|
📱 New catalog for testing generated: Download |
yes! helper text added both in catalog and in screenshot baseline |
🥅 What's the goal?
Search Input in compose as defined in Mistica specs:
🚧 How do we do it?
SearchInputcomposable similar to other existing input implementation.☑️ Checks
🧪 How can I test this?
Grabacion.de.pantalla.2024-09-10.a.las.10.06.53.mov